Repository navigation
Feature/intercept custom sessions - #6
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Merge pull request #4 from Rev0212/feature/intercept-custom-sessions
…m/Rev0212/iOS-NetworkInspector into feature/intercept-custom-sessions
There was a problem hiding this comment.
🟡 Changes recommended
The forwarding session sets protocolClasses to an empty array, which can disable request loading by removing the default protocol stack.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR extends NetworkInspector’s interception coverage to URLSessions created from their own URLSessionConfiguration (e.g., third-party SDKs) by injecting InspectorURLProtocol into freshly created default/ephemeral configurations via class-method swizzling.
Changes:
- Swizzles
URLSessionConfiguration.defaultand.ephemeralfactory getters to ensure returned configurations includeInspectorURLProtocol. - Updates
InspectorURLProtocol’s internal forwarding session configuration to avoid self-interception. - Adds tests to verify protocol injection and idempotent installation.
File summaries
| File | Description |
|---|---|
| Tests/NetworkInspectorTests/NetworkInspectorTests.swift | Adds tests asserting injected protocol classes and idempotent swizzle installation. |
| Sources/NetworkInspector/URLSessionConfigurationSwizzle.swift | Implements thread-safe, once-only swizzle of default/ephemeral factory getters to seed protocolClasses. |
| Sources/NetworkInspector/InspectorURLProtocol.swift | Adjusts the forwarding session configuration to avoid replay loops after the new injection behavior. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+21
to
+24
| // `default` is swizzled to seed InspectorURLProtocol; leaving it in place here would point | ||
| // this forwarding session back at ourselves. The handled-request flag already breaks that | ||
| // loop, but keeping it off the replay session means we never rely on it. | ||
| config.protocolClasses = [] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.