chore: upgrade Calcit and ignore .DS_Store - #1
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Upgrades Calcit to 0.13.27, migrates project metadata, and refreshes the Yarn 4 lockfile.
Changes:
- Updates Calcit dependencies and generated snapshots.
- Removes legacy
package.cirru. - Updates environment fallback handling.
- The advertised
.DS_Storeignore rule is not included.
Reviewed changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Summary and findings |
|---|---|
yarn.lock |
Yarn 4 lockfile. Critical (1 vote): CI does not enable or pin Yarn 4 before installation. |
package.json |
Updates Calcit and Yarn versions. Critical (1 vote): CI still pins cr/caps 0.8.8, incompatible with the migrated format. Nit (3 votes): .DS_Store ignore rule is missing. |
package.cirru |
Removes legacy package metadata. |
compact.cirru |
Updates environment fallback syntax. |
calcit.cirru |
Migrates to the new Calcit snapshot format. Critical (1 vote): CI’s pinned cr/caps 0.8.8 tooling is incompatible with this format. |
Suppressed comments (1)
package.json:2
- This switches the repository to Yarn 4 and a v8 lockfile, but the existing Actions workflow still invokes bare
yarnwithout enabling Corepack. On a fresh runner that can resolve to the preinstalled Yarn 1, which cannot install this lockfile, so the build job can fail before Vite runs. Enable/pin Corepack (or invoke the Yarn 4 binary explicitly) in the workflow before the install step.
"packageManager": "yarn@4.12.0",
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+2
to
+4
| {} (:about "|Machine-generated snapshot. Do not edit directly — changes will be overwritten. Use `cr query` to inspect and `cr edit`/`cr tree` to modify. Run `cr docs agents --full` first. Manual edits must follow format and schema conventions, then run `cr edit format`.") (:package |app) | ||
| :entries $ {} | ||
| :default $ {} (:description |) (:init-fn 'app.main/main!) (:mode :native) (:reload-fn 'app.main/reload!) |
| @@ -1,6 +1,7 @@ | |||
| { | |||
| "packageManager": "yarn@4.12.0", | |||
tiye
commented
Aug 21, 2026
| :defs $ {} | ||
| |dev? $ %{} :CodeEntry (:doc |) | ||
| :code $ quote | ||
| def dev? $ = "\"dev" (get-env "\"mode" "\"release") |
Member
Author
There was a problem hiding this comment.
已经有新版本的 calcit.cirru , 那么就不需要 compact.cirru 了
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
本 PR 基于最新 origin/main，包含本次 Calcit 依赖/格式升级及 .DS_Store 忽略规则。
已完成本地检查；请等待 Actions 全部成功后再合并，本 PR 不应自动合并。