Repository navigation
Fix crossover using stale HTML5 currentTime after seek-before-load - #27
Merged
Merged
Conversation
When gotoTrack set pausedAtTrackTime before the HTML5 element finished loading, the crossover would overwrite it with audio.currentTime (~1.3s) instead of preserving the correct seek position (e.g. 31.5s). Now _crossoverHtml5ToWebAudio prefers pausedAtTrackTime when it exceeds audio.currentTime. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Deploying gapless with
|
| Latest commit: |
41da099
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0ed6e79d.gapless-e1l.pages.dev |
| Branch Preview URL: | https://fix-crossover-seek-offset.gapless-e1l.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gotoTrack(idx, false, 31.5)setspausedAtTrackTimebefore the HTML5 element finishes loading,_crossoverHtml5ToWebAudiowas overwriting it withaudio.currentTime(~1.3s), causing the WebAudio source to start from the wrong offset.pausedAtTrackTimeoveraudio.currentTimewhen the seek position hasn't been reflected in the HTML5 element yet.Test plan
vitest run tests/unit/crossover-flow.test.ts— 10/10)crossover preserves pausedAtTrackTime when HTML5 element has not caught up to a prior seek🤖 Generated with Claude Code