TESTING: scale the RFP xTFSM forward error by the solution norm - #1398
Open
ACSimon33 wants to merge 1 commit into
Open
TESTING: scale the RFP xTFSM forward error by the solution norm#1398ACSimon33 wants to merge 1 commit into
ACSimon33 wants to merge 1 commit into
Conversation
The unnormalised difference against xTRSM failed the threshold at a relative error under 2 ulp, on a solve whose solution reaches 4e6. The floor of 1 covers ALPHA = 0, where the solution is exactly zero. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
martin-frbg
approved these changes
Sep 9, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1398 +/- ##
==========================================
- Coverage 68.99% 68.99% -0.01%
==========================================
Files 6122 6122
Lines 486386 486402 +16
Branches 23286 23286
==========================================
+ Hits 335575 335583 +8
- Misses 150622 150630 +8
Partials 189 189
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Harness.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #679
Problem
stest_rfpreportsSTFSM: 1 out of 7776 tests failed to pass the thresholdon the x86-64 gfortran CI jobs (static and shared, plain and OpenMP).Cause
xDRVRF3checks xTFSM against xTRSM with an absolute forward error:Nothing in that refers to the size of the solution, and the driver deliberately builds ill-conditioned systems — see its own comment, "Forcing main diagonal of test matrix to be unit makes it ill-conditioned for some test cases". When the solution grows large the test fails on a difference that is negligible in relative terms.
Measured on the failing case (
CFORM='T' SIDE='L' UPLO='U' TRANS='T' DIAG='N' M=N=50):|X|_inf = 3.88e6,|dX|_inf = 0.788, i.e. a relative difference of 2.03e-07 — under 2 single-precision ulp — reported astest = 45.665against a threshold of 30. The two routines agree to rounding; only the measure is wrong.Change
Divide by
MAX(SOLNRM, 1), whereSOLNRMis the norm of the xTRSM solution.Applied identically in all four precisions.