Skip to content

HMS-11167: fix Systems cards - #1745

Merged
Dugowitch merged 6 commits into
RedHatInsights:masterfrom
Dugowitch:sys-cards
Aug 11, 2026
Merged

HMS-11167: fix Systems cards#1745
Dugowitch merged 6 commits into
RedHatInsights:masterfrom
Dugowitch:sys-cards

Conversation

@Dugowitch

@Dugowitch Dugowitch commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Description

Associated Jira ticket: HMS-11167

Fix various Systems cards issues, described in detail in commit description if needed.

How to test the PR

  1. npm run start:stage
  2. try filtering with cards
  3. check visually
  4. scale the page

Before the change

image

After the change

image

Checklist:

  • The commit message has the Jira ticket linked
  • PR has a short description
  • Screenshots before and after the change are added
  • Tests for the changes have been added
  • README.md is updated if necessary
  • Needs additional dependent work

@codecov-commenter

codecov-commenter commented Aug 6, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.40%. Comparing base (5211923) to head (1ebbf23).

Files with missing lines Patch % Lines
src/SmartComponents/Systems/SystemsMainContent.js 50.00% 3 Missing ⚠️
src/store/Reducers/SystemsStore.js 0.00% 3 Missing ⚠️
...nalComponents/StatusReports/SystemsStatusReport.js 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1745      +/-   ##
==========================================
- Coverage   77.49%   77.40%   -0.10%     
==========================================
  Files         102      102              
  Lines        3302     3315      +13     
  Branches      759      760       +1     
==========================================
+ Hits         2559     2566       +7     
- Misses        664      670       +6     
  Partials       79       79              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Dugowitch
Dugowitch marked this pull request as ready for review August 6, 2026 09:41
@Dugowitch
Dugowitch requested a review from a team as a code owner August 6, 2026 09:41
@Dugowitch Dugowitch changed the title Sys cards HMS-11167: fix Systems cards Aug 6, 2026
@dominikvagner dominikvagner self-assigned this Aug 6, 2026
Dugowitch and others added 6 commits August 11, 2026 11:29
HMS-11167

Add an action that replaces query params rather than combining with the
already applied ones. It will be used when filtering based on Systems
cards interaction. It is added because `apply`, used until now, would
not clear already applied filters, leading to an unexpedcted number of
systems being displayed.
HMS-11167

Co-Authored-By: Claude <noreply@anthropic.com>
HMS-11167

This mechanic forces InventoryTable to rerender and update its inner
state to the new state with updated filters after clicking systems card.

Co-Authored-By: Claude <noreply@anthropic.com>

@dominikvagner dominikvagner left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! ✨ nice job 🙇🏼

the UI tests are currently broken due to the issue with stage DB :/

ack ✅

@Dugowitch
Dugowitch merged commit eb86102 into RedHatInsights:master Aug 11, 2026
5 of 7 checks passed
@Dugowitch
Dugowitch deleted the sys-cards branch August 11, 2026 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants