Fix broken Cypress CI workflows on both Windows and Linux#588
Open
joanise wants to merge 2 commits into
Open
Conversation
Fixes unreliable and repeatedly broken tests by just running the steps directly, which appears to be more reliable.
|
Review changes with Changed Files
|
Contributor
|
joanise
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Goal?
Fix running Cypress tests in CI.
On Linux, that mysteriously starting needed an explicit
npx cypress install, not sure why that stopped happening implicitly.On Windows, things were just a lot more broken, so I fell back to hand writing our steps to run Cypress like we do interactively, and really, it's much simpler, so maybe we should do the same on Linux too...
Bumping the version of Cypress because I first hoped that would fix the broken workflows. It did not, but we might as well keep the update.
Fixes?
Broken CI
Feedback sought?
sanity checking
Priority?
high -- CI is currently broken on main
How to test?
See CI results
Confidence?
high
Version change?
no