Fix timeout handling in SchedulerToExecutorService.awaitTermination - #8301
Merged
Conversation
Signed-off-by: cuishuang <imcusg@gmail.com>
akarnokd
approved these changes
Sep 5, 2026
🐷 TruffleHog + Entropy Beauty ScanAverage entropy of changed code: 4.592 bits/char Changed files entropy: ✅ No secrets or suspicious high-entropy strings found. Mid-4 beauty heuristic in action — powered by our entropy chats! 😊 |
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (84.61%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## 4.x #8301 +/- ##
=========================================
Coverage 98.61% 98.62%
- Complexity 7148 7158 +10
=========================================
Files 824 824
Lines 50791 50800 +9
Branches 6911 6913 +2
=========================================
+ Hits 50086 50099 +13
+ Misses 481 476 -5
- Partials 224 225 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes timeout handling in SchedulerToExecutorService.awaitTermination().
The previous implementation converted the timeout in the wrong direction:
For example, awaitTermination(1, TimeUnit.SECONDS) converted the value to zero and returned immediately without waiting.