Add convar for spectate order#1079
Draft
anf3is wants to merge 2 commits into
Draft
Conversation
preparation for next commit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to support custom spectating order (for example: Jaeger → Wildcat → Vegas → [other/fallback]).
The configured order should be respected when cycling between marines while preserving the current behavior that all alive marines remain valid spectate targets.
WIP Info
SpectateNextMarineis server-side. Because of that we need to send client's spectate order to server.newmapsettings.cfgis too early forrd_set_spectate_order😭rd_set_spectate_orderoperates onCASW_Player. Do we need to callrd_set_spectate_orderafter client is fully connected andCASW_Playerfor this client is created?Tasks
rd_spectate_orderfor storing client's preferencesrd_set_spectate_orderifrd_spectate_orderis setrd_set_spectate_orderas hidden