Misc refactors to appease the compiler#1078
Draft
anf3is wants to merge 30 commits into
Draft
Conversation
move type into for rename filter.GetRecipientCount rename RGB -> RGBnext rename for loop i -> j rename KeyValues fix i visiblity remove unused attackerTeam rename index -> iIndex rename pPRecipient rename mass -> massHeld remove unused result of V_snprintf inline fPhysObjectMass rename pPlayer -> pPClient inline count fix sit visibility (while -> for) inline dir rename te -> tempEntity rename pTartget -> pTarget2 rename a -> ia rename inc -> incAdj rename color -> blockedColor move x declaration inside scopes where it is used rename hFunc -> hScopedFunc
maybe missed some outcommented
maybe missed some outcommented
maybe missed some outcommented
maybe missed some outcommented
inline getstat move dir and angles inside rename overshadowed i -> j move int i inside for rename te -> tempEntity inline effects rename observerTarget inline bVisible specify ParticleEffect and ControlPoint variables rename idx rename iBuffAttachment rename outer i remove unused var tPos rename p -> p2 move int declare into for rename info -> infoNew fix i -> t fix i -> j rename i -> idx rename pMaterialWf rename msg -> kvMsg move white and blue remove duplicate fDelay rename buf ->pathBuf remove duplicate nNumHistogramBuckets rename textTall -> smallTextTall rename kv -> kvActive add scope for player helper rename matrix -> matrix2 rename i -> tail renames in bWireframe rename msg -> kvMsg rename pButton -> phButton rename pProfile -> pProfilePref rename uvScale -> uvScale2 inline GetModelType rename pEntry -> pEntry2 rename nNumShadows -> nNumBlobbyShadows rename angle -> angle_yaw/angle_pitch rename input -> x_input rename w/h -> text_w/text_h rename iRenderCache -> tail remove unused GetBounds add ifndef INFESTED_DLL for hudCloseCaption definition remove duplicated definition of fBracketTime
anf3is
force-pushed
the
rf/fix-compiler-warnings
branch
from
bb4a36a to
a3fae8f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most of these changes are simple renames to prevent name collisions between:
Nearly all renames were performed using LSP rename.
All trivial changes have been squashed.
I'm not fully sure about changes in the remaining unsquashed commits. If anyone sees a cleaner solution or finds any error there, I'd appreciate suggestions before I squash them and mark the PR as ready for review.
I'm also not so sure about wider
refactor(client): rename ...commits, but this PR compiles and the game runs just fine.