Feature/breast data - #36
Conversation
📝 WalkthroughWalkthroughThis change adds breast MMCI dataset configurations and exploration adapters for B20-24 and MammaPrint data. It wires preprocessing experiments, updates tile filtering and embedding settings, sets model dropout values, and renames the project for carcinoma classification. ChangesBreast data pipeline
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
participant Hydra
participant ExplorationAdapter
participant MLflow
participant MetadataAndTiling
Hydra->>ExplorationAdapter: Load dataset configuration
ExplorationAdapter->>MLflow: Download metadata and tiling artifacts
ExplorationAdapter->>MetadataAndTiling: Normalize metadata and repair tiling datasets
MetadataAndTiling->>MLflow: Log repaired datasets and metadata artifacts
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
|
@coderabbitai review |
✅ Action performedReview finished.
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@exploration/mammaprint_test.py`:
- Around line 37-48: Normalize the MammaPrint metadata before writing
mammaprint_test_metadata.csv so it exposes slide_path as required by the
pipeline, preprocessors, and v2 tiling. Update the metadata setup associated
with config.original_metadata, or apply the existing B20-24 adapter’s
rename-and-drop contract to df before repair_and_log and CSV logging; preserve
all other metadata behavior.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 37ee6e1b-6ca1-4362-a81e-c5fc17cdffd7
⛔ Files ignored due to path filters (1)
uv.lockis excluded by!**/*.lock
📒 Files selected for processing (32)
configs/data/breast/base.yamlconfigs/data/breast/mmci/b20_24_base.yamlconfigs/data/breast/mmci/b20_24_full.yamlconfigs/data/breast/mmci/b20_24_train.yamlconfigs/data/breast/mmci/b20_24_val.yamlconfigs/data/breast/mmci/base.yamlconfigs/data/breast/mmci/mammaprint_test.yamlconfigs/data/breast/mmci/stats.yamlconfigs/experiment/preprocessing/filter_tiles/b20_24_train.yamlconfigs/experiment/preprocessing/filter_tiles/b20_24_val.yamlconfigs/experiment/preprocessing/filter_tiles/mammaprint_test.yamlconfigs/experiment/preprocessing/tile_embeddings_v2/pgp/b20_24_train.yamlconfigs/experiment/preprocessing/tile_embeddings_v2/pgp/b20_24_val.yamlconfigs/experiment/preprocessing/tile_embeddings_v2/pgp/mammaprint_test.yamlconfigs/experiment/preprocessing/tile_embeddings_v2/virchow2/b20_24_train.yamlconfigs/experiment/preprocessing/tile_embeddings_v2/virchow2/b20_24_val.yamlconfigs/experiment/preprocessing/tile_embeddings_v2/virchow2/mammaprint_test.yamlconfigs/experiment/preprocessing/tile_masks/b20_24_val_224.yamlconfigs/experiment/preprocessing/tile_masks/b20_24_val_512.yamlconfigs/experiment/preprocessing/tile_masks/mammaprint_test_512.yamlconfigs/exploration/breast/b20_24.yamlconfigs/exploration/breast/base.yamlconfigs/exploration/breast/mammaprint_test.yamlconfigs/model/pgp_full_model.yamlconfigs/model/pgp_model.yamlconfigs/model/virchow2_full_model.yamlconfigs/model/virchow2_model.yamlconfigs/preprocessing/tile_embeddings_v2.yamlexploration/b20_24.pyexploration/mammaprint_test.pypreprocessing/tiling_v2/filter_tiles.pypyproject.toml
Summary by CodeRabbit