Update seeds for E2E tests - #983
Merged
Merged
Conversation
Test coverage93.43% line coverage reported by SimpleCov. |
raspberrypiherokubot
temporarily deployed
to
editor-api-p-excs-sso-j-fnih91
August 25, 2026 17:07
Inactive
mwtrew
marked this pull request as ready for review
August 26, 2026 09:10
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Rails rake-based E2E seeding tasks to create additional school setup data used by end-to-end scenarios.
Changes:
- Adds a new “unassigned teacher” test user ID and ensures their roles are cleaned up during seed teardown.
- Seeds an
example.comschool email domain and assigns the additional teacher to the seeded school.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lib/tasks/test_seeds.rake | Adds an extra teacher seed user, cleans up their roles on destroy, and seeds a school email domain + teacher assignment. |
| lib/tasks/seeds_helper.rb | Introduces a new TEST_USERS[:johan_doe] entry for the additional seeded teacher user. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
zetter-rpf
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
What's changed?
example.comto the test school