Identify Experience CS projects - #975
Draft
cocomarine wants to merge 5 commits into
Draft
Conversation
Test coverage93.43% line coverage reported by SimpleCov. |
raspberrypiherokubot
temporarily deployed
to
editor-api-p-1717-add-p-loqwkl
August 20, 2026 14:16
Inactive
zetter-rpf
reviewed
Aug 21, 2026
…in-column # Conflicts: # app/models/project.rb # spec/features/project/creating_a_project_spec.rb # spec/models/project_spec.rb
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a first-class origin attribute to Project to mark Experience CS-created projects, with validations to allow backfill and prevent later modification, and ensures the origin is set during Experience CS admin/service project creation and preserved through remixing.
Changes:
- Add
projects.origincolumn + partial index for non-null origins. - Enforce origin validation (known origins only, allow
nil, immutable once set). - Set origin during Experience CS admin/service project creation; ensure remixes inherit origin; add corresponding specs.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
app/models/project.rb |
Defines Origins::EXPERIENCE_CS and adds validation + immutability guard for origin. |
lib/concepts/project/operations/create.rb |
Sets origin for Experience CS admins (incl. service account) during project creation. |
db/migrate/20260820122510_add_origin_to_projects.rb |
Adds origin column and index for querying/filtering by origin. |
db/schema.rb |
Reflects the new origin column and index in schema. |
spec/models/project_spec.rb |
Covers origin inclusion validation and immutability on update. |
spec/features/project/creating_a_project_spec.rb |
Verifies origin is set when an Experience CS admin creates a project via REST. |
spec/concepts/project/create_spec.rb |
Verifies Project::Create sets origin only for Experience CS admins. |
spec/concepts/project/create_remix_spec.rb |
Verifies remixes copy origin from the original project. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+3
to
+8
| class AddOriginToProjects < ActiveRecord::Migration[8.1] | ||
| def change | ||
| add_column :projects, :origin, :string | ||
| add_index :projects, :origin, where: 'origin IS NOT NULL' | ||
| end | ||
| end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
Points for consideration:
What's changed?
origincolumn to Projectinclusionin known origins (onlyProject::Origins::EXPERIENCE_CSfor now)originfrom original project.