test: Stop leaking workspaces from Mocha tests - #10322
Merged
Merged
Conversation
lizschwab
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Proposed Changes
This PR updates the Mocha tests to properly dispose of workspaces that they create. Previously, after the full test suite was run,
Blockly.common.getAllWorkspaces()returned 992 workspaces; it now returns an empty array. This both improves performance (on Chrome, the test suite goes from about 20 seconds to 7 seconds) and likely correctness, since the old discarded workspaces aren't hanging around in limbo for future tests.This also fixes a leak in core (the trashcan never disposed of its flyout) and improves the robustness of getting the focusable element for connections (the old approach was problematic if the parent block had been detached from the DOM).
Test Coverage
Is less leaky and faster.