[Bugfix]: Only run GPU tests on HIP backend - #504
Open
daniellegillai wants to merge 2 commits into
Open
Conversation
daniellegillai
marked this pull request as draft
August 7, 2026 23:57
daniellegillai
marked this pull request as ready for review
August 7, 2026 23:58
Collaborator
|
@levxn can you validate this on both CPU and HIP backend. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: ran out of time to test that nothing broke on the HIP backend, and to review more carefully which tests should be HIP only. But with that test and review, this should otherwise be ready.
Motivation
Fixes #500: when rocAL is compiled with CPU backend, does not run the GPU tests.
Technical Details
Modified the tests/cpp_api/CMakeLists.txt to guard the GPU tests with a BACKEND check. Also emits a message when skipping GPU tests in cmake step.
Test Plan
Built TOT rpp and MIVisionX with CPU backends, then built rocAL with -DBACKEND=CPU. Ran CTests.
Note: ran out of time to test that nothing broke on the HIP backend, and to review more carefully which tests should be HIP only. But with that test and review, this should otherwise be ready.
Test Result
Only runs non-GPU tests on CPU backend, passes all: