[NFCI] Make check_smoke.sh shellcheck-compliant#2313
Merged
mhalk merged 2 commits intoJul 1, 2026
Merged
Conversation
Addressed ~130 ShellCheck findings Actual behavior change might stem from `|| exit / return` Co-authored-by: Cursor <cursoragent@cursor.com>
mhalk
requested review from
carlobertolli,
estewart08,
gregrodgers,
ronlieb and
zGoldthorpe
as code owners
Collaborator
Author
|
FYI my system's shellcheck (version 0.8.0-2) did not flag this finding. |
jplehr
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressed ~130 ShellCheck findings
Actual behavior change might stem from
|| exit / returnMotivation
Unrelated changes triggered ShellCheck GH action fail.
See: #2308
Technical Details
"Mechanically" addressed each ShellCheck finding.
Test Plan
Ran smoke limbo tests locally, which uses this script via symlink.
Test Result
Resulting output was identical.
Submission Checklist