Skip to content

[gfx1250] fused_moe: require GUGU gu_interleave layout - #5015

Merged
zufayu merged 1 commit into
mainfrom
jiaxiwen/gfx1250-fused-moe-gu-interleave
Aug 27, 2026
Merged

[gfx1250] fused_moe: require GUGU gu_interleave layout#5015
zufayu merged 1 commit into
mainfrom
jiaxiwen/gfx1250-fused-moe-gu-interleave

Conversation

@lalala-sh

@lalala-sh lalala-sh commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Summary

  • gfx1250 grouped GEMM only consumes GUGU (gate/up row-interleaved) w1, not 16-row block shuffle.
  • fused_moe now raises if G1U1 callers on gfx1250 pass a gate_mode other than interleave.

Test plan

  • On gfx1250, run grouped GEMM UT with gate_mode=interleave (should still pass accuracy).
  • On gfx1250, call fused_moe with G1U1 + gate_mode=separated and confirm it raises ValueError.
  • Non-gfx1250 paths unchanged.

Made with Cursor

Grouped GEMM on gfx1250 only consumes gate/up row-interleaved w1, so reject G1U1 calls that are not gate_mode=interleave.

Co-authored-by: Cursor <cursoragent@cursor.com>
@lalala-sh
lalala-sh requested a review from a team August 26, 2026 09:37
@github-actions

Copy link
Copy Markdown
Contributor

🏷️ CI Guide

Runs automatically on every PR:

  • ✅ Pre-checks (submodule verification, code formatting)
  • ✅ Aiter op tests (gfx942 + gfx950)
  • ✅ Triton tests on MI35X (only when aiter/ops/triton/** or related paths are changed)

Extended tests (opt-in via labels):

Label Tests
ci:gfx1250-ffm-triton Run the five-shard gfx1250 FFM Triton test suite
ci:triton-300x Run an additional Triton test job on MI300X in PRs; main branch always runs both MI35X and MI300X
ci:sglang SGLang integration tests: DeepSeek-R1-MXFP4 accuracy, Qwen 3.5 accuracy
ci:atom ATOM benchmark: DeepSeek-R1-0528, GPT-OSS-120B
ci:atom_full ATOM accuracy suite for PR and main models from ATOM models_accuracy.json
ci:vllm vLLM benchmark: GPT-OSS-120B, DeepSeek-R1-0528, Kimi-K2.5
ci:all All standard extended tests (excludes ci:atom_full)

Only add ci:atom_full for FlyDSL or Triton upgrades.
Add labels via the sidebar or gh pr edit 5015 --add-label <label>

PR title tags:
Component tags ([Triton/Gluon], [HIP], [CK], [ASM], ...) are added to the PR title automatically from the changed files and re-synced on every push — change-type tags like [fix]/[Perf] and op tags like [MLA] are left untouched. Add the no-auto-title label to opt this PR out of title tagging.

@github-actions github-actions Bot changed the title [HIP] [gfx1250] fused_moe: require GUGU gu_interleave layout [gfx1250] fused_moe: require GUGU gu_interleave layout Aug 26, 2026
@lalala-sh
lalala-sh requested a review from zufayu August 26, 2026 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants