[gfx1250] fused_moe: require GUGU gu_interleave layout - #5015
Merged
Conversation
Grouped GEMM on gfx1250 only consumes gate/up row-interleaved w1, so reject G1U1 calls that are not gate_mode=interleave. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
🏷️ CI GuideRuns automatically on every PR:
Extended tests (opt-in via labels):
PR title tags: |
zufayu
approved these changes
Aug 27, 2026
This was referenced Aug 27, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
w1, not 16-row block shuffle.fused_moenow raises if G1U1 callers on gfx1250 pass agate_modeother thaninterleave.Test plan
gate_mode=interleave(should still pass accuracy).fused_moewith G1U1 +gate_mode=separatedand confirm it raisesValueError.Made with Cursor