fix: track expected pipelines correctly - #88
Open
cgoea wants to merge 2 commits into
Open
Conversation
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #57:
EXPECTED_PIPELINE_TYPEStreats pytorch/jax as always expected on every release, regardless of whether this release's own dispatch actually enabled them (build_pytorch/build_jax). Since #66's fix (this PR is stacked on #86 ), a platform correctly waits for every expected sibling pipeline to report before crystallizing, but a genuinely disabled pytorch/jax has no way to signal that, so it renders a wedgingin_progressplaceholder and holds the platform pending for the entire live window.Technical Details
rollup_sibling_statuses()and the per-pipelinesibling_statusesstructure introduced there, so it should be merged after fix: platform status stays in_progress #86.Test Plan
skippedimmediately and doesn't hold the platform; enabled pytorch/jax holds the platform pending pastcompleted_at; resolves cleanly once it actually reports.therock_update_status_json_test.pyfor the input-capture path: orchestrator-start capture, setup-run capture, missing-input default, string-bool parsing, and new-owner reset.Test Result
442 passed
Submission Checklist