Skip to content

fix: track expected pipelines correctly - #88

Open
cgoea wants to merge 2 commits into
developfrom
users/cgoea/track_expected_pipelines
Open

fix: track expected pipelines correctly#88
cgoea wants to merge 2 commits into
developfrom
users/cgoea/track_expected_pipelines

Conversation

@cgoea

@cgoea cgoea commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Motivation

Fixes #57: EXPECTED_PIPELINE_TYPES treats pytorch/jax as always expected on every release, regardless of whether this release's own dispatch actually enabled them (build_pytorch/build_jax). Since #66's fix (this PR is stacked on #86 ), a platform correctly waits for every expected sibling pipeline to report before crystallizing, but a genuinely disabled pytorch/jax has no way to signal that, so it renders a wedging in_progress placeholder and holds the platform pending for the entire live window.

Technical Details

Test Plan

  • Added dedicated tests for the new behavior: disabled pytorch/jax renders skipped immediately and doesn't hold the platform; enabled pytorch/jax holds the platform pending past completed_at; resolves cleanly once it actually reports.
  • Added tests in therock_update_status_json_test.py for the input-capture path: orchestrator-start capture, setup-run capture, missing-input default, string-bool parsing, and new-owner reset.

Test Result

442 passed

Submission Checklist

@cgoea
cgoea requested review from a team and HereThereBeDragons August 26, 2026 10:52
@cgoea cgoea changed the title Users/cgoea/track expected pipelines fix: track expected pipelines correctly Aug 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant