docker: fix ATOM and SGLang release builds - #2013
Open
ThomasNing wants to merge 1 commit into
Open
Conversation
Contributor
🏷️ CI GuideRuns automatically on every eligible PR before approval:
Heavy model tests:
|
ThomasNing
force-pushed
the
fix/docker-install-protobuf-compiler
branch
2 times, most recently
from
August 25, 2026 00:21
3777c57 to
863ff27
Compare
ThomasNing
force-pushed
the
fix/docker-install-protobuf-compiler
branch
from
August 25, 2026 00:57
863ff27 to
b916f9a
Compare
ThomasNing
force-pushed
the
fix/docker-install-protobuf-compiler
branch
4 times, most recently
from
August 25, 2026 01:39
8f8dea2 to
09120d7
Compare
ThomasNing
force-pushed
the
fix/docker-install-protobuf-compiler
branch
from
August 25, 2026 01:45
09120d7 to
f132e62
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
protobuf-compilerandlibprotobuf-devfor the ATOM mesh Rust buildReproduction
The official release-image path was built and exercised end-to-end on an 8x MI350X (gfx950) host using the Dockerfile default ROCm 7.2.4 / PyTorch 2.10 base. Failures were found sequentially.
The mesh build initially lacked the compiler and then Ubuntu's well-known protobuf definitions:
On the 192-core builder, unbounded Cargo parallelism exhausted Docker's 1,024-file descriptor limit:
After the unified ATOM+SGLang image built, GLM-5.2-MXFP4 SGLang TP4 exposed three prerequisites present in SGLang's own ROCm Dockerfile but absent from ATOM's SGLang layer:
Installing the PyPI TileLang wheel was insufficient because ATOM subsequently pins another TVM FFI revision, producing an ABI failure during DSA execution:
This change therefore follows pinned SGLang v0.5.17 exactly: TileLang commit
a55a8230, TVM FFI commit37d0485b, and ROCm FHT commit46efb7d7. TileLang is built in an isolated stage so repairing the base image's apt dependency state cannot replace the runtime's custom RCCL package. The QuickAllReduce message is resolved by installing/opt/rocm/share/amd_smi. The new build arguments remain overridable, and expensive earlier layers stay cacheable. No runtime source patch is applied.Validation
git diff --checkprotoc --versionand both imported definitions in the pinned base imageREADYfrom/v1/chat/completions0.1.7.post3+cuda.gita55a8230, TVM FFI0.1.8.post3.dev42+g37d0485b2