Repository navigation
Conversation
…only Fixes REditorSupport#1516 Signed-off-by: Don Yin <Don_Yin@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1516.
I reproduced this with a read-only default library and no user library: accepting the prompt to install
languageserverfailed withunable to install packages. I changed the prerequisite installer to createR_LIBS_USERonly when the default library isn't writable, and pass it explicitly toinstall.packages().I left sess unchanged:
install_sess.Rnow requiresVSCODE_R_SESS_LIBRARY, so the fallback linked in the issue is no longer there to share.I added one focused test. It fails on main and passes with the change, and the utility/installer tests, lint, formatting, typecheck and production build pass locally.