feat(ductile-fracture): load finalized plots, SEM datasets and dictionary review #233 - #38
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ductile Fracture — finalized data load (#233)
Loads the finalized ductile-fracture dataset delivered by @andskia (replacing the
single-specimen placeholder), applies his data-dictionary review, and enables SEM
for the specimens that now have imagery. Stacks on the
material/nesting (#37,already merged).
Contents
force_elongation(102),force_radial(85 — 17 specimens have noexperimental radial data; simulation-only for those), and the five
*_simulationseries (102 each: force-elongation, force-radial, equivalentplastic strain, lode angle, triaxiality).
sem/<id>/(stored as Git-LFS, per theexisting
*.tiffilter):and 12 Ozden et al. CNT coupons imaged on both fracture surfaces
(
_2suffix → surface 2).most
(?)markers (piece,crack_opening_direction,exc_at_fract,step_fract, CNT diameter fields, …).has_sem— set toyesfor the 36 SEM specimens,nootherwise.Validation
Ran the full uploader (
all-ductile-fractures) against a clean local Postgres —zero errors. Row counts: 102 parent specimens,
has_sem=true= 36,force_radialcovers 85 distinct specimens, all 7 series tables populated.Reviewer / @andskia follow-ups (non-blocking)
swdfm_*andkk_*rows have descriptions but theirsymbolcolumn is still empty (Andskia's@add symbol@notes).kk_*descriptions were changed Kanvinde-Kiran →Kiran-Khandelwal per the review; please confirm.
elongation_frstill carries a(?)(not covered by the review).extra_017.tifinSkiadopoulos_..._CNT_EXT_M_C3_R10_0(location "extra", magnification 17) wasexcluded as it fits no naming/magnification convention. Confirm if it was
meaningful.
Notes
manifest.jsonfor the 36SEM specimens are produced + uploaded separately via
make precompute-sem(EPFL CDN). Until that runs, the 36 SEM dialogs will 404.
HEAD~1..HEAD).