Skip to content

feat(tensile_coupons): initial dataset & dictionary - #36

Merged
pierreleripoll merged 4 commits into
mainfrom
data/tensile-coupons-initial-load
May 21, 2026
Merged

feat(tensile_coupons): initial dataset & dictionary#36
pierreleripoll merged 4 commits into
mainfrom
data/tensile-coupons-initial-load

Conversation

@pierreleripoll

@pierreleripoll pierreleripoll commented Apr 20, 2026

Copy link
Copy Markdown
Collaborator

Initial data drop for the Tensile Coupons subtab under Materials (tracks RESSLab-Team/resslab-hub#230).

Contents

  • tensile_coupons/tensile_coupons.csv — 15 specimens × 70 columns (Wen, Skiadopoulos, Ashida & Lignos, 2026)
  • tensile_coupons/tensile_coupons_data_dictionary.csv — dictionary drafted from descripton_of_items_19_04_2026.docx + master CSV
  • tensile_coupons/stress_strain/{specimen_id}.csv — 15 engineering stress-strain curves, id-as-filename
  • README.md — added tensile_coupons/ to the supported directories list

Points for @dlignos & @andskia

  1. Column renames (SQLAlchemy/Python reject % in identifiers — CSV and dictionary both updated):
    • specimen_idid (codegen treats only the literal id as the primary key, matching every other table)
    • yield_stress_02%__mpa_yield_stress_02__mpa_, yield_strain_02%yield_strain_02
    • elongation_at_fracture__%_ / elongation_after_fracture__%_ / reduction_of_area__%_ → drop the __%_ suffix (unit % stays in the dictionary)
    • Chemical composition c__%_fe__%_cfe (matches the Materials DB convention)
  2. bin_discont_yield stored as yes/no instead of 1/0 — the uploader's Boolean convention (used by columns.cfe and connections.slab/backing_bar/aisc_pz_violation_*) is case-insensitive yes/no. NA stays as-is.
  3. b, zr, sn, ca, h, fe are 100% NA in the current 15 rows. Kept as DecimalFloat, nullable=True with placeholder example values — swap in real ones if available.

@pierreleripoll
pierreleripoll requested review from andskia and dlignos and removed request for andskia and dlignos April 20, 2026 17:24
@dlignos

dlignos commented May 2, 2026

Copy link
Copy Markdown
Contributor

Initial data drop for the Tensile Coupons subtab under Materials (tracks RESSLab-Team/resslab-hub#230).

Contents

  • tensile_coupons/tensile_coupons.csv — 15 specimens × 70 columns (Wen, Skiadopoulos, Ashida & Lignos, 2026)
  • tensile_coupons/tensile_coupons_data_dictionary.csv — dictionary drafted from descripton_of_items_19_04_2026.docx + master CSV
  • tensile_coupons/stress_strain/{specimen_id}.csv — 15 engineering stress-strain curves, id-as-filename
  • README.md — added tensile_coupons/ to the supported directories list

Points for @dlignos & @andskia

  1. Column renames (SQLAlchemy/Python reject % in identifiers — CSV and dictionary both updated):

    • specimen_idid (codegen treats only the literal id as the primary key, matching every other table)

DL: OK

  • yield_stress_02%__mpa_yield_stress_02__mpa_, yield_strain_02%yield_strain_02

DL: OK

  • elongation_at_fracture__%_ / elongation_after_fracture__%_ / reduction_of_area__%_ → drop the __%_ suffix (unit % stays in the dictionary)

DL: OK

  • Chemical composition c__%_fe__%_cfe (matches the Materials DB convention)

DL: OK

  1. bin_discont_yield stored as yes/no instead of 1/0 — the uploader's Boolean convention (used by columns.cfe and connections.slab/backing_bar/aisc_pz_violation_*) is case-insensitive yes/no. NA stays as-is.

DL: OK

  1. b, zr, sn, ca, h, fe are 100% NA in the current 15 rows. Kept as DecimalFloat, nullable=True with placeholder example values — swap in real ones if available.

DL: OK

@pierreleripoll see under each one of your points - overall we agree with the adaptations.

@dlignos

dlignos commented May 2, 2026

Copy link
Copy Markdown
Contributor

@pierreleripoll all clear - this is correct.

@pierreleripoll
pierreleripoll merged commit 8c5424a into main May 21, 2026
3 checks passed
@pierreleripoll
pierreleripoll deleted the data/tensile-coupons-initial-load branch May 21, 2026 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants