Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SOCA 0.2.0 selects accounts by verified email and binds callbacks only to the User-Agent. This change requires a separate browser secret and an approved issuer/subject association, closing copied-callback and email-only account-selection gaps.
Reviewed against shared requirements revision 60ea4db. docs/REQUIREMENTS.md records all 34 statuses, source digest, evidence, limits and remaining gaps.
Changes
Migration and limits
Existing users require administrator-approved issuer/subject links and a fresh candidate test before SSO rollout. Preserve local administrator access. Existing 0.2.0 settings/keys and WordPress sessions remain. This PR does not publish a release.
This increment does not complete every shared target. Multiple providers, full algorithm support, claim mapping/inspection, provider logout and restore-safe revocation remain tracked gaps. Inline key-set changes require another admitted test and explicit recovery if pairwise subjects change. Provisioning uses compensation rather than a database transaction. Live RESOAuth login and a current complete self-hosted browser login remain unverified.
Validation
31 protocol groups pass on PHP 8.1/8.3/8.5; 23 WordPress groups, two deployment checks, one emergency check, 22 Chromium scenarios, three concurrency scenarios and seven multisite groups pass. Psalm, WordPressCS and local Semgrep checks pass; Composer audit reports no known advisories. Syntax, release metadata, requirement IDs/Markdown links, repeated deterministic ZIP builds and archive checks pass. Tests used isolated disposable WordPress 7.1.3/PHP 8.3/MariaDB 11.4 installations with synthetic providers. Reproduction and evidence limits are in docs/TESTING.md.