Reconnecting doesn't have the same cleanup as logging out - #59
Merged
Merged
Conversation
Swan
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes it so that reconnecting after a disconnect within around 2 minutes doesn't bug out the multiplayer lobby. Without it the lobby softlocks on the "waiting for players" screen and shows the user staying listed in the lobby after they've already left.
The cause was that reconnecting only removed the old session from the session maps, but skipped the rest of the cleanup that a normal logout does like removing the player from their game and the lobby and telling everyone they disconnected. By the time the old dead connection was finally detected as closed the session was already gone so that cleanup never ran. The fix makes reconnecting run that same cleanup instead of just deleting the old session.