Skip to content

Remove ImageSharp dependencies #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
A6sT wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Remove ImageSharp dependencies #222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3811dba
Removed ImageSharp references and replaced it by our own helper's class
A6sT Jul 6, 2026
e4f0ddc
Merge branch 'master' of https://github.com/A6sT/Quaver.API
A6sT Jul 6, 2026
5a38ee6
Removed helper's class to use SkiaSharp instead
A6sT Jul 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 23 additions & 5 deletions Quaver.API/Maps/AutoMod/AutoMod.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
using Quaver.API.Maps.Structures;
using Quaver.API.Replays;
using Quaver.API.Replays.Virtual;
using SixLabors.ImageSharp;
using SkiaSharp;

namespace Quaver.API.Maps.AutoMod
{
Expand Down Expand Up @@ -445,15 +445,33 @@ private void DetectImageFileIssues(string item, string path, int maxSize, int mi
if (new FileInfo(path).Length > maxSize)
Issues.Add(new AutoModIssueImageTooLarge(item, maxSize));

if (!TryGetImageDimensions(path, out var width, out var height))
return;

if (width < minWidth || height < minHeight || width > maxWidth || height > maxHeight)
Issues.Add(new AutoModIssueImageResolution(item, minWidth, minHeight, maxWidth, maxHeight));
}

private static bool TryGetImageDimensions(string path, out int width, out int height)
{
width = 0;
height = 0;

try
{
using (var image = Image.Load(path))
if (image.Width < minWidth || image.Height < minHeight || image.Width > maxWidth || image.Height > maxHeight)
Issues.Add(new AutoModIssueImageResolution(item, minWidth, minHeight, maxWidth, maxHeight));
using (var codec = SKCodec.Create(path))
{
if (codec == null)
return false;

width = codec.Info.Width;
height = codec.Info.Height;
return width > 0 && height > 0;
}
}
catch (Exception)
{
// ignored
return false;
}
}

Expand Down
3 changes: 2 additions & 1 deletion Quaver.API/Quaver.API.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@
<PackageReference Include="MonoGame.Extended" Version="1.1.0" />
<PackageReference Include="MoonSharp" Version="2.0.0" />
<PackageReference Include="Newtonsoft.Json" Version="11.0.2" />
<PackageReference Include="SixLabors.ImageSharp" Version="2.1.8" />
<PackageReference Include="SkiaSharp" Version="4.148.0" />
<PackageReference Include="SkiaSharp.NativeAssets.Linux.NoDependencies" Version="4.148.0" />
<PackageReference Include="sqlite-net-pcl" Version="1.5.231" />
<PackageReference Include="YamlDotNet" Version="5.1.0" />
<PackageReference Include="z440.atl.core" Version="3.18.0" />
Expand Down
Loading