Skip to content

fix: 个人资料绑定卡片未应用自定义 OIDC 显示名称 - #6933

Open
feitianbubu wants to merge 1 commit into
QuantumNous:mainfrom
feitianbubu:pr/9cd6495b4
Open

fix: 个人资料绑定卡片未应用自定义 OIDC 显示名称#6933
feitianbubu wants to merge 1 commit into
QuantumNous:mainfrom
feitianbubu:pr/9cd6495b4

Conversation

@feitianbubu

@feitianbubu feitianbubu commented Aug 19, 2026

Copy link
Copy Markdown
Member

📝 变更描述 / Description

cb4c8c0 (#6012) 加了自定义 OIDC 显示名称,登录按钮已生效,但个人资料页的绑定卡片漏了,仍然写死 "OIDC"。改成读 status.oidc_display_name,未配置时回退原样。

🚀 变更类型 / Type of change

  • 🐛 Bug 修复 (Bug fix)
  • ✨ 新功能 (New feature)
  • ⚡ 性能优化 / 重构 (Refactor)
  • 📝 文档更新 (Documentation)

🔗 关联任务 / Related Issue

✅ 提交前检查项 / Checklist

  • 人工确认: 我已亲自整理并撰写此描述,没有直接粘贴未经处理的 AI 输出。
  • 非重复提交: 我已搜索现有的 IssuesPRs,确认不是重复提交。
  • Bug fix 说明: 若此 PR 标记为 Bug fix,我已提交或关联对应 Issue,且不会将设计取舍、预期不一致或理解偏差直接归类为 bug。
  • 变更理解: 我已理解这些更改的工作原理及可能影响。
  • 范围聚焦: 本 PR 未包含任何与当前任务无关的代码改动。
  • 本地验证: 已在本地运行并通过测试或手动验证,维护者可以据此复核结果。
  • 安全合规: 代码中无敏感凭据,且符合项目代码规范。

📸 运行证明 / Proof of Work

修复前:
image

修复后:
image

Summary by CodeRabbit

  • Improvements
    • OIDC account bindings now display the server-provided name when available.
    • A default “OIDC” label remains available when no valid custom name is provided.

@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: ff922297-b589-457b-a644-559518ebda53

📥 Commits

Reviewing files that changed from the base of the PR and between f116414 and cd56b07.

📒 Files selected for processing (1)
  • web/src/features/profile/components/tabs/account-bindings-tab.tsx

Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review.


Walkthrough

The OIDC account binding label now uses a trimmed server-provided display name. It falls back to the translated OIDC label when the display name is absent or contains only whitespace.

Changes

OIDC binding label

Layer / File(s) Summary
Display name fallback
web/src/features/profile/components/tabs/account-bindings-tab.tsx
The OIDC label uses status?.oidc_display_name?.trim() when non-empty and falls back to t('OIDC').

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to cd56b

The personal profile binding card now follows the configured OIDC display name while retaining the existing fallback behavior. This is a localized presentation fix with no actionable merge-blocking risk remaining.

Possibly related PRs

Suggested reviewers: seefs001

Poem

I nibbled the label, neat and bright,
The server name now sits just right.
If only spaces cross the floor,
“OIDC” appears as before.
A tidy bind, a happy hare.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed 标题准确描述了个人资料绑定卡片未应用自定义 OIDC 显示名称这一主要修复。
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant