Skip to content

More tests for CUDA + MPS#406

Open
kshyatt wants to merge 8 commits into
mainfrom
ksh/cu2
Open

More tests for CUDA + MPS#406
kshyatt wants to merge 8 commits into
mainfrom
ksh/cu2

Conversation

@kshyatt

@kshyatt kshyatt commented Mar 26, 2026

Copy link
Copy Markdown
Member

Revealed a bunch more missing things needing fixes, so I will keep this as draft for now.

@github-actions

github-actions Bot commented May 7, 2026

Copy link
Copy Markdown
Contributor

Your PR no longer requires formatting changes. Thank you for your contribution!

@kshyatt

kshyatt commented May 17, 2026

Copy link
Copy Markdown
Member Author

The algorithms tests are failing as a consequence of QuantumKitHub/BlockTensorKit.jl@677d141, because now JordanMPOTensor needs to accept also Union types in addition to AbstractTensorMap...

Fake news: it's due to git eating part of the changes to main I was rebasing on top of...

Comment thread src/operators/jordanmpotensor.jl Outdated
@codecov

codecov Bot commented Jun 9, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 88.46154% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
ext/MPSKitAdaptExt.jl 0.00% 2 Missing ⚠️
src/operators/jordanmpotensor.jl 80.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
src/operators/abstractmpo.jl 85.81% <100.00%> (+0.70%) ⬆️
src/operators/mpo.jl 86.48% <100.00%> (ø)
src/operators/mpohamiltonian.jl 90.90% <100.00%> (+0.55%) ⬆️
src/operators/ortho.jl 100.00% <100.00%> (ø)
src/operators/jordanmpotensor.jl 83.41% <80.00%> (+2.94%) ⬆️
ext/MPSKitAdaptExt.jl 91.30% <0.00%> (-8.70%) ⬇️

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kshyatt kshyatt marked this pull request as ready for review June 10, 2026 10:03
Comment thread src/operators/abstractmpo.jl Outdated
Comment thread src/operators/abstractmpo.jl Outdated
Comment thread src/operators/jordanmpotensor.jl Outdated
Comment thread src/operators/ortho.jl Outdated

@lkdvos lkdvos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some final small comments, otherwise good to go for me!

Comment thread test/gpu/cuda/operators.jl Outdated
Comment thread test/gpu/cuda/operators.jl Outdated
@kshyatt

kshyatt commented Jun 11, 2026

Copy link
Copy Markdown
Member Author

Left some final small comments, otherwise good to go for me!

Great, let me get tests fixed up and try to do a little more housekeeping and I'm happy too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants