Credit Adisankar Manoj Thanuja as translator of the ml edition - #10
Merged
Conversation
quantecon-book-theme v0.22.0 adds a `translators` theme option, parallel to
`authors`, so a translated edition can credit the people who produced it in
the page header. This edition's Malayalam text is the work of Adisankar Manoj
Thanuja, who is already recorded as the primary editor in `.translate/config.yml`.
Bumps the theme pin from 0.21.0 to 0.22.0, which is what makes the option do
anything, and adds the single-entry `translators` list. The `translators_label`
default ("Translated by") is left in place for now; localising it to Malayalam
is a separate call best made by a native speaker.
See QuantEcon/quantecon-book-theme#426
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Enables translator crediting in the site header for the Malayalam edition by upgrading the QuantEcon book theme to a version that supports the new translators option, and configuring a single translator entry in the book config.
Changes:
- Bumps
quantecon-book-themefrom0.21.0to0.22.0to pick up support for thetranslatorstheme option. - Adds a
translatorsentry (name + URL) underhtml_theme_optionsinlectures/_config.yml.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
environment.yml |
Updates the theme pin to quantecon-book-theme==0.22.0 so the new config option is recognized. |
lectures/_config.yml |
Adds a translators list to display “Translated by …” in the header for the Malayalam edition. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
|
📖 HTML build - view preview (383a0bb) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
quantecon-book-theme v0.22.0 adds a
translatorstheme option, parallel toauthors, so a translated edition can credit the people who produced it right in the page header. This turns it on for the Malayalam edition and credits Adisankar Manoj Thanuja, who is already recorded as the primary editor in.translate/config.ymland whose native-speaker review rounds produced the Malayalam text we ship.Changes
environment.yml0.21.0→0.22.0— the option is a no-op without itlectures/_config.ymltranslatorslist underhtml_theme_optionsThe header renders Translated by Adisankar Manoj Thanuja, right-aligned on the "Last changed" line one row below the authors, so the credit costs the header no extra vertical space. On narrow screens the two lines stack. Translators are shown on content pages but not on the landing page.
Two things worth a look before merging
The label is still English.
translators_labeldefaults toTranslated by, and the theme lets each edition override it so the credit renders in its own language. I left the default rather than guess at Malayalam wording — the two natural candidates areവിവർത്തനം:(the standard print-credit form, reads cleanly before a Latin-script name) andവിവർത്തനം ചെയ്തത്(a more literal "translated by"). Happy to add whichever @adisankarmt prefers, here or in a follow-up.The credit is project-wide, but only
python_by_examplehas had a native review round so far. Every other lecture is still machine output. The theme's docs are explicit that a machine-translated page in an otherwise translated edition should not carry a human's name, and they provide the mechanism for it: a page settingtranslators: []in its front matter suppresses the block on that page only. If we would rather not attach Adisankar's name to the unreviewed pages yet, the alternative is to drop the project-level entry and settranslatorsper page as each lecture clears review. Flagging the choice rather than making it — happy to switch this PR to the per-page approach if that is the call.Verification
Both files parse, and the
translatorsvalue round-trips through PyYAML in the documented list-of-mappings shape.0.22.0is live on PyPI. I have not built the site locally — the header rendering above is from the theme's own docs andlayout.html, not from a build I ran.See QuantEcon/quantecon-book-theme#426 for the upstream feature.
🤖 Generated with Claude Code