Skip to content

Credit Adisankar Manoj Thanuja as translator of the ml edition - #10

Merged
mmcky merged 1 commit into
mainfrom
add-translator-credit
Aug 25, 2026
Merged

Credit Adisankar Manoj Thanuja as translator of the ml edition#10
mmcky merged 1 commit into
mainfrom
add-translator-credit

Conversation

@mmcky

@mmcky mmcky commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

quantecon-book-theme v0.22.0 adds a translators theme option, parallel to authors, so a translated edition can credit the people who produced it right in the page header. This turns it on for the Malayalam edition and credits Adisankar Manoj Thanuja, who is already recorded as the primary editor in .translate/config.yml and whose native-speaker review rounds produced the Malayalam text we ship.

Changes

File Change
environment.yml Theme pin 0.21.00.22.0 — the option is a no-op without it
lectures/_config.yml Adds a single-entry translators list under html_theme_options

The header renders Translated by Adisankar Manoj Thanuja, right-aligned on the "Last changed" line one row below the authors, so the credit costs the header no extra vertical space. On narrow screens the two lines stack. Translators are shown on content pages but not on the landing page.

Two things worth a look before merging

The label is still English. translators_label defaults to Translated by, and the theme lets each edition override it so the credit renders in its own language. I left the default rather than guess at Malayalam wording — the two natural candidates are വിവർത്തനം: (the standard print-credit form, reads cleanly before a Latin-script name) and വിവർത്തനം ചെയ്തത് (a more literal "translated by"). Happy to add whichever @adisankarmt prefers, here or in a follow-up.

The credit is project-wide, but only python_by_example has had a native review round so far. Every other lecture is still machine output. The theme's docs are explicit that a machine-translated page in an otherwise translated edition should not carry a human's name, and they provide the mechanism for it: a page setting translators: [] in its front matter suppresses the block on that page only. If we would rather not attach Adisankar's name to the unreviewed pages yet, the alternative is to drop the project-level entry and set translators per page as each lecture clears review. Flagging the choice rather than making it — happy to switch this PR to the per-page approach if that is the call.

Verification

Both files parse, and the translators value round-trips through PyYAML in the documented list-of-mappings shape. 0.22.0 is live on PyPI. I have not built the site locally — the header rendering above is from the theme's own docs and layout.html, not from a build I ran.

See QuantEcon/quantecon-book-theme#426 for the upstream feature.

🤖 Generated with Claude Code

quantecon-book-theme v0.22.0 adds a `translators` theme option, parallel to
`authors`, so a translated edition can credit the people who produced it in
the page header. This edition's Malayalam text is the work of Adisankar Manoj
Thanuja, who is already recorded as the primary editor in `.translate/config.yml`.

Bumps the theme pin from 0.21.0 to 0.22.0, which is what makes the option do
anything, and adds the single-entry `translators` list. The `translators_label`
default ("Translated by") is left in place for now; localising it to Malayalam
is a separate call best made by a native speaker.

See QuantEcon/quantecon-book-theme#426

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings August 25, 2026 10:11

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Enables translator crediting in the site header for the Malayalam edition by upgrading the QuantEcon book theme to a version that supports the new translators option, and configuring a single translator entry in the book config.

Changes:

  • Bumps quantecon-book-theme from 0.21.0 to 0.22.0 to pick up support for the translators theme option.
  • Adds a translators entry (name + URL) under html_theme_options in lectures/_config.yml.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
environment.yml Updates the theme pin to quantecon-book-theme==0.22.0 so the new config option is recognized.
lectures/_config.yml Adds a translators list to display “Translated by …” in the header for the Malayalam edition.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@github-actions

Copy link
Copy Markdown
Contributor

📖 HTML build - view preview (383a0bb)

@mmcky
mmcky merged commit e1069db into main Aug 25, 2026
5 checks passed
@mmcky
mmcky deleted the add-translator-credit branch August 25, 2026 10:19
github-actions Bot added a commit that referenced this pull request Aug 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants