doubts_or_variability: drop the pandas-datareader install nothing imports - #381
Open
mmcky wants to merge 1 commit into
Open
doubts_or_variability: drop the pandas-datareader install nothing imports#381mmcky wants to merge 1 commit into
mmcky wants to merge 1 commit into
Conversation
…orts The lecture deliberately reads FRED's CSV endpoint (its own comment says so) and never imports pandas_datareader; only the install line survived the switch. Removing it changes no output and shrinks the build environment. The two intro lectures in the same inventory were cleaned up in QuantEcon/lecture-python-intro#803, so this is the last of the three. See QuantEcon/data-lectures#26. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
✅ Deploy Preview for lustrous-melomakarona-3ee73e ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
Removes a vestigial pip install pandas-datareader setup cell from the doubts_or_variability lecture, aligning the notebook with its current approach of downloading FRED data directly via the fredgraph.csv endpoint (i.e., no pandas_datareader usage).
Changes:
- Deleted the introductory text and hidden code cell that installed
pandas-datareader. - Leaves the lecture’s existing direct-FRED download path unchanged (no functional/output changes expected).
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The lecture reads FRED's
fredgraph.csvendpoint directly — its own in-lecture comment records that this was deliberate — and never importspandas_datareader, so the!pip install pandas-datareadercell is a leftover from before that switch. Removing it and its one-sentence lead-in changes no output and drops a package from the build environment.This is item 1 of the recommendation on QuantEcon/data-lectures#26 (delete the vestigial installs, independent of any decision about the package). The inventory named three lectures; the two in
lecture-python-intro(networks,input_output) were already cleaned up in QuantEcon/lecture-python-intro#803, so this is the last one.🤖 Generated with Claude Code