Repository navigation
deps: sphinx-exercise 1.2.2 in both images - #312
Merged
Merged
Conversation
sphinx-exercise 1.2.2 writes a captioned figure inside an exercise or
solution box as \begin{figure}[H], so pdflatex no longer stops with
"LaTeX Error: Not in outer par mode". lecture-python.myst moved to
1.2.2 when it restored figure captions in its solutions, and the full
image's exact 1.2.1 pin failed that repository's PDF build in lecture
matrix run 42942041680. The lean image's floor moves with it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WT8bMbZoC2dpGt3sPyBjyd
Contributor
There was a problem hiding this comment.
Note
Copilot was unable to complete this review at the selected tier due to model policy or plan restrictions.
🟢 Approval recommended
The changes are limited to straightforward dependency version bumps for sphinx-exercise across the two container environment files, and the review evidence indicates there are no outstanding issues to resolve.
No open issues 🎉
What changed in this PR
Updates both container images to use sphinx-exercise 1.2.2 so downstream PDF builds behave consistently and avoid the LaTeX failure triggered by captioned figures inside exercise/solution boxes.
Changes:
- Bump the full
quanteconimage pip pin fromsphinx-exercise==1.2.1to==1.2.2. - Raise the
quantecon-buildimage minimum fromsphinx-exercise>=1.2.1to>=1.2.2to align the version floor across images.
| File | Description |
|---|---|
| containers/quantecon/environment.yml | Updates the full image’s pip dependency pin to sphinx-exercise==1.2.2. |
| containers/quantecon-build/environment.yml | Raises the lean build image’s minimum sphinx-exercise version requirement to >=1.2.2. |
Review effort: Balanced
This was referenced Nov 11, 2026
Merged
mmcky
added a commit
that referenced
this pull request
Nov 11, 2026
Cut ## [0.19.0] - 2026-11-11 below an empty ## [Unreleased], with the entry #312 owed: sphinx-exercise 1.2.2 in both images. PLAN's release line names v0.19.0, with @v0 on v0.18.0 until the release gate passes it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WT8bMbZoC2dpGt3sPyBjyd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Lecture-matrix run 42942041680, dispatched on
mainto test #307 on all eight legs, failed one:lecture-python.myst · quantecon, at "Build PDF (No Execution)". pdflatex stopped withLaTeX Error: Not in outer par modeat a\begin{figure}[htbp]inside an exercise solution.QuantEcon/lecture-python.myst#1121 (merged 2026-11-11 00:26 UTC) restored figure captions in its solutions and moved that repository to
sphinx-exercise==1.2.2. sphinx-exercise 1.2.2 (released 2026-11-10) writes a captioned figure inside an exercise or solution box as\begin{figure}[H], as Sphinx does inside its own admonitions, which is what pdflatex needs there. The fullquanteconimage pinssphinx-exercise==1.2.1exactly, and the matrix doesn't apply a lecture'senvironment.ymlto it, so that leg built with 1.2.1. Thequantecon-buildleg of the same repository ran 1.2.2 and passed its PDF build.Changes
containers/quantecon/environment.ymlsphinx-exercise==1.2.1→==1.2.2containers/quantecon-build/environment.ymlsphinx-exercise>=1.2.1→>=1.2.2, so the lean image's floor matches, as #293 did for the themeBoth are pip entries, and 1.2.2 is on PyPI. No other file in the repository names a sphinx-exercise version.
What I checked
sphinx-exercise 1.2.1; the passinglecture-python.myst · quantecon-buildleg lists1.2.2.quantecon-build.ci.ymlandpublish.ymlinstall itsenvironment.ymlwith setup-miniconda, so its published site was never affected.After merge
The merge rebuilds both images, promotes them to
:latestonce the smoke tests pass, and starts a lecture-matrix run, which should turnlecture-python.myst · quantecongreen. Merge it on its own, not while a lecture-matrix run is in progress. Its CHANGELOG entry goes in the next release PR, as #293's did.Not in this PR
Any other image dependency: Dependabot's weekly conda run covers those.
Claude Code (on behalf of mmcky)
🤖 Generated with Claude Code
https://claude.ai/code/session_01WT8bMbZoC2dpGt3sPyBjyd