Repository navigation
fix(cloud): push project libraries when using --push in cloud commands - #725
Open
pcbeingused333 wants to merge 1 commit into
Open
pcbeingused333 wants to merge 1 commit into
pcbeingused333 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #719
lean cloud backtest/optimize/live deploy <project> --pushresolves the project throughCloudProjectManager.get_cloud_project, which calledPushManager.push_projects([local_path])without the project's libraries. The project itself was pushed, but the libraries it references were not, so the cloud ran against stale or missing library code.lean cloud pushdoes not have this problem becausePushManager.push_projectpassesget_project_libraries(project).Fix: in both push branches of
get_cloud_project(local project directory and cloud name/id resolved to a local directory), passProjectManager.get_project_libraries(local_path)as the associated libraries topush_projects, the same waypush_projectdoes.Tests:
tests/components/cloud/test_cloud_project_manager.pygets a new test with a project that references a library and asserts the library is passed topush_projects; the three existing push tests now assert the new call shape. All four fail without the change and pass with it.This change was prepared with the help of an AI assistant (Claude), and the submitter is responsible for it.