Use compensated summation in applyCompMatr CPU path#788
Open
qdwg wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cpu_statevec_anyCtrlAnyTargDenseMatr_sub().applyCompMatr/left-right multiplication APIs.amps[i] += elem * cache[j]accumulation with a local sum plus Neumaier compensation for real and imaginary components.Validation
Built and tested locally on macOS with CPU-only, non-OpenMP configuration. The local CommandLineTools default SDK did not expose C++ standard library headers, so I had to point CMake at the installed MacOSX15.5 SDK C++ include path.
Result: all tests passed, 5879 assertions in 2 test cases.
Notes
applyCompMatraccuracy with compensated summation #598.AI disclosure
This contribution was developed with assistance from OpenAI Codex. I reviewed the patch and ran the validation above before submitting.
Closes #598.