Repository navigation
fix(chat): make composer nav buttons readable in dark mode - #99
Merged
Merged
Conversation
The new-tab, new-conversation, and chat-history buttons above the input used --text-faint, the dimmest text token, for their default icon color. Against the dark workspace background that measured ~2.6:1 contrast, so the icons were nearly invisible until hovered. Use --text-muted like the other composer controls (~7:1), keeping the hover state at --text-normal. Co-authored-by: QoderAI (Qwen 3.8 Max) <qoder_ai@qoder.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.qoderian-input-nav-btn) used--text-faint, Obsidian's dimmest text token, for their default icon color. In dark mode that measured 2.57:1 contrast against the workspace background (#666666on#282828) — below the WCAG 3:1 minimum for graphical objects — so the icons were nearly invisible until hovered (hover jumps to--text-normal).--text-muted, the same token the other composer controls already use, raising contrast to 7.03:1 (#b3b3b3on#282828). Hover stays--text-normal. One-line CSS change, no!important, consistent with sibling buttons.Verification
npm run typechecknpm run lintnpm run test(3611 passed)npm run buildnpm run release:checknpm run audit:prod(0 vulnerabilities)Safety
CHANGELOG.md