Skip to content

feat: add file_types to Option and FileUpload - #3449

Closed
plun1331 wants to merge 5 commits into
masterfrom
feat/file-types
Closed

plun1331 wants to merge 5 commits into
masterfrom
feat/file-types

Conversation

@plun1331

Copy link
Copy Markdown
Member

Summary

Option sucks and we should rewrite it

no ai

untested as of now

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.
  • I have read the Contributing Guidelines.
  • AI Usage has been disclosed.
    • If AI has been used, I understand fully what the code does

ToothyDev and others added 2 commits November 16, 2026 18:37
….user` (#3425)

* Make User | Member option unions work properly

* Add changelog

* Address change requests

* Update CHANGELOG.md

Co-authored-by: Paillat <paillat@pycord.dev>
Signed-off-by: ToothyDev <55001472+ToothyDev@users.noreply.github.com>

* Remove unnecessary extra check

* chore: Update old `Optional[...]` syntax to use new `type | None` syntax (#3407)

* Update old None-types to use correct syntax

This will make None clickable in the docs and lead to the python docs

* Documentation changes

* Code changes

* Fix up extra space

* Apply change requests and fix docs

* Apply change requests

Co-authored-by: Michael <8661717+sgtlaggy@users.noreply.github.com>

* Update new leftover Optionals use

* Update old :data:None to use obj:None style

Napoleon seems to internally use this style as well, so I'm choosing it over the existing :data: type

---------

Co-authored-by: Michael <8661717+sgtlaggy@users.noreply.github.com>

---------

Signed-off-by: ToothyDev <55001472+ToothyDev@users.noreply.github.com>
Signed-off-by: Paillat <paillat@pycord.dev>
Co-authored-by: Paillat <paillat@pycord.dev>
Co-authored-by: Michael <8661717+sgtlaggy@users.noreply.github.com>
@plun1331
plun1331 requested review from a team November 16, 2026 19:30
@github-project-automation github-project-automation Bot moved this to Todo in Pycord Nov 16, 2026
@plun1331
plun1331 requested a review from JustaSqu1d November 16, 2026 19:30
@pycord-app

pycord-app Bot commented Nov 16, 2026

Copy link
Copy Markdown

Thanks for opening this pull request!
Please make sure you have read the Contributing Guidelines and Code of Conduct.

This pull request can be checked-out with:

git fetch origin pull/3449/head:pr-3449
git checkout pr-3449

This pull request can be installed with:

pip install git+https://github.com/Pycord-Development/pycord@refs/pull/3449/head

@Paillat-dev

Copy link
Copy Markdown
Member

#3284 ?

@plun1331 plun1331 left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i didnt look that hard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants