Repository navigation
fix(voice): correct UDP keep-alive interval unit - #3436
Conversation
|
Thanks for opening this pull request! This pull request can be checked-out with: git fetch origin pull/3436/head:pr-3436
git checkout pr-3436This pull request can be installed with: pip install git+https://github.com/Pycord-Development/pycord@refs/pull/3436/head |
|
Git blames @Lulalaby introducing this in #3143 and I assume that's because of the mix between Python's Not sure if this one needs a changelog @Paillat-dev (?) |
|
@vmphase that PR was largely by DA344 + me btw not Lala, she just opened the PR, so she is not to blame if anything |
|
We do have an issue too lol #3388 |
|
Yes please changelog @vmphase, thx |
I really wonder what sdeparte/kb-meeting-agent#1 is, and why did it mention that issue 🤔 |
Summary
Currently the voice receiver's thread sleeps ~83 minutes instead of 5 seconds which is subnormal. However, e.g. djs or DisCatSharp sleep for 5 seconds (
Task.Delayin C# andsetIntervalin JS accept milliseconds).UPD: Fixes #3388.
Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.