Fix dtype layout tests on 32-bit targets - #564
Open
heiserhorn wants to merge 1 commit into
Open
Conversation
Author
|
The Debian i386 validation is now complete: a clean sbuild of rust-numpy 0.28.0-4 passes with the dtype-layout patch applied. The follow-up i386 failure was a separate exact borrow-flag-count assertion in borrow::shared::tests::borrow_multiple_arrays (left: 2, right: 1). It is documented in issue #565, with the Debian-side portability patch and successful i386 build details: Debian MR !1317 now contains both patches in signed commit cd5eb68c16: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make dtype alignment and aligned-record layout tests portable to 32-bit targets.
On i386, NumPy reports 4-byte alignment for the tested scalar and subarray dtypes, and the aligned record has itemsize 16 and alignment 4. The tests currently hard-code the 64-bit values 8 and 24, causing
dtype::tests::test_dtype_methods_recordand related tests to fail on i386.The library behavior is unchanged; the assertions now select the expected values using
target_pointer_width. This addresses the i386 failure observed while packaging rust-numpy 0.28.0 in Debian.