CI: removed automatic Claude code review workflow - #791
Merged
Conversation
Reviews are now on-request only, by mentioning @claude in a PR or issue comment (handled by claude.yml). The automatic pull_request-triggered review could never work for PyLops' fork-based flow anyway: GitHub gives fork PR jobs a read-only token, never sets ACTIONS_ID_TOKEN_REQUEST_URL so OIDC fails, and withholds repository secrets. The issue_comment trigger runs in the base-repo context, where both are available. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Up to standards ✅🟢 Issues
|
mrava87
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes
.github/workflows/claude-code-review.yml, the workflow that ran a Claude review automatically on everypull_requestevent. Code reviews are now on-request only: mention@claudein a PR or issue comment andclaude.ymlhandles it.Why
The automatic workflow could never work with PyLops' fork-based contribution flow. For
pull_requestevents originating from a fork, GitHub:GITHUB_TOKEN,ACTIONS_ID_TOKEN_REQUEST_URL, soid-token: writehas no effect and OIDC token retrieval fails, andCLAUDE_CODE_OAUTH_TOKEN.It failed on #790 with
Could not fetch an OIDC token, and would have failed the same way on every external contributor's PR.The
issue_commenttrigger inclaude.ymlis unaffected: it runs in the base-repository context from the default branch, where both OIDC and secrets are available. This was confirmed working on fork PR #790 in this run. As a bonus, the action only responds to commenters with write access by default, so external contributors can't trigger it unprompted.🤖 Generated with Claude Code