Repository navigation
fix: treat media times beyond TimeSpan range as unknown - #5
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chromium on Linux reports a stream without a known length (Disney+) as
mpris:length9223372036854775807, far beyond what a TimeSpan holds, so every read threw anOverflowExceptionand flooded the log. A length or position that is negative, not finite or too large now counts as unknown, so the stream shows no duration instead of failing.The check lives in
MediaTimeand covers MPRIS, macOS Now Playing and mpv, which converted raw numbers the same way. Windows gets its timeline as TimeSpans already and was not affected.Reproduced with Disney+ in Chromium on Linux.
Fixes #4