Repository navigation
Pin audiodsp f763ec3: a compiled graph renders on the audio pump's core - #175
Merged
Merged
Conversation
… image doesn't restore a venv it can't run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the audiodsp pin to f763ec3 (PyDevices/audiodsp#317). An
audiograph.Graphcan now be played as a source the audio pump pulls, so on esp32 it renders on the pump's core rather than the interpreter's, andset()reaches it through a queue drained at block boundaries.Checked on an ESP32-P4 board with the WIFI6_DEV_KIT_H2 variant, built from the audiodsp branch that merged as f763ec3: a two-voice Poly6 played for 32 minutes with the LVGL panel open and a WebSocket client changing parameters, and no audio block was starved.
The second commit fixes CI. ubuntu-latest moved from 24.04 to 26.04, but the cached CircuitPython toolchain (
deps/circuitpython-venv,~/.espressif) was still keyed only on deps.lock, so the new image restored a venv built for the old image's Python. CircuitPython's make then failed withNo module named 'minify_html'. Both that cache and the firmware release's cache now include the runner's Python version in their key.