Repository navigation
dir() on a CPython struct lists its fields and methods - #48
Merged
Merged
Conversation
CPython struct types resolve fields and methods in getattro, so object.__dir__ never saw them. Each struct type now has a __dir__ that adds them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #40. #47 has merged, so this is based on main.
On CPython,
dir()on a struct instance now lists the struct's fields and methods. Struct types resolve these by name ingetattro, soobject.__dir__never saw them. Each struct type now has a__dir__that adds them.The MicroPython build already listed fields. On the current Unix build,
dir(lv.grad_dsc_t())showsstops,paramsand the gradient methods. The new test checks it there too.The new smoke test
test_struct_dirfailed on CPython before this change withdir(grad_dsc_t()) is missing ['stops', 'dir', 'extend', 'params', 'linear_init']. It passes after, along with the rest of the smoke test. pytest (109) passes andregenerate_all.sh --checkmatches.