Repository navigation
Move AUDIODSP_PIN to audiodsp f98eb17, the 128-voice sampler - #201
Merged
Merged
Conversation
f98eb17 carries audiosampler's 128-voice ceiling (audiodsp#289) and the fix for audiodsp#290: #284's splice search no longer runs on a fading repeat, which had dropped PitchShifter's third repeat 19 dB under its bar at 22.05 kHz, -5 semitones and Feedback 0.3. T3 passes again, with that cell back at 2.5 dB over its reference. #284 still moves the two `@options` rows of test_measure_effect_cost, which run the loop shifter on held material; their digests are re-read.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AUDIODSP_PINmoves from 6db15e3 to audiodsp f98eb17. That commit raises audiosampler's voice ceiling to 128 (audiodsp#289), so a SoundFont pool built withmax_voice_countabove 64 gets the voices it asks for.The last attempt at this move, to c03a357 in #199, turned two gates red. Both came from audiodsp#284, whose splice search searches on.
PitchShifter'sT3TheRepeatsfailed. At 22,050 Hz, -5 semitones and Feedback 0.3, the third repeat read 19 dB under its bar's reference. That was a regression: the far search also ran on a fading repeat, where there was nothing to match. audiodsp#291 fixes it (audiodsp#290), and the cell reads 2.5 dB over again, as it did before #284. All 560 T3 cells and seeds pass, the worst at -5.3 dB.test_the_damping_row_turns_the_loop_low_pass_onis a golden. Its two@optionsrows run the loop shifter on held material, which is what #284 changed, so the new digests are written in. Under f98eb17 they match c03a357's byte for byte.Tests
Run against audiodsp built from the pin the way CI builds it (
_audiodsp.__revision__reads v0.6.8.dev4-3-gf98eb17). These tests use the sampler or PitchShifter:test_cpython_effects_pitchshifter,test_cpython_effects_rack,test_midi_dispatch,test_cpython_sf2,test_cpython_soundfont,test_cpython_soundfont_gm,test_measure_effect_cost, andtest_lifecycle_matrixscoped to PitchShifter. All 206 pass. For the matrix's MicroPython leg, MicroPython was built from the same audiodsp.