Repository navigation
Effects: Expander's tail follows Key Listen; classes state their residue beside the tail; Distortion's reset residue is held - #198
Merged
Conversation
…due beside the tail; Distortion's reset residue is held Expander (#146): with Key Listen on, tail_samples bounds the key filters' ring from Key Low, Key High and the rate; it stays 0 with Key Listen off. A test holds the bound across the key settings and shows a tail of 0 red. #155: Compressor, DynamicEQ, MultibandCompressor, DeEsser, CombFilter, Exciter, Fuzz, Overdrive and Distortion state the residue that outlasts tail_samples beside TAIL_SAMPLES. Distortion's reset residue (787 LSB mono, 630 stereo) is held under 800 by a test, with a reset that leaves the drive up shown red.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #146. Fixes #155.
Expander, Key Listen on (#146).
tail_samplessaid 0 while the key filters rang for 2,304 frames or more. With Key Listen on it now bounds that ring from Key Low, Key High and the rate: about 5,100 frames at 48 kHz with Key Low at its minimum, against a measured 2,373 (1,568 to 2,688 on the burst probes used here), and shorter as Key Low rises. With Key Listen off it is still 0. A test holds the ring under the bound at five Key Low and Key High pairs and at 0 with Key Listen off; a class that declares 0 with Key Listen on is shown red. The issue stays open for the LadderFilter and delay-family halves.Residue beside the tail (#155). Compressor, DynamicEQ, MultibandCompressor, DeEsser, CombFilter, Exciter, Fuzz, Overdrive and Distortion each say, beside
TAIL_SAMPLES, how far the output can stand from an untouched copy after a reset, a rejoin or a control move, with the figures the lifecycle matrix measured. Distortion's slow coupling-pole residue after a reset was written as about 700 LSB; on the matrix's E1 material it reads 787 mono and 630 stereo over the 20,000 frames after the tail, so the docs now say up to about 800, and a test holds it under 800. A reset that leaves the drive at full is shown red against that bound.Run:
tests.test_cpython_effects_expanderand_distortion(83 tests, OK), the lifecycle matrix for Expander on CPython, MicroPython and CircuitPython (656 cells, 64 red, the same lines on all three and the same rows the known table holds),tools/validate_api.py,tools/validate_metadata.py, flake8. Not run here: the full suite.