Skip to content

Fix vSkip.ical_value returning the enum name - #2106

Open
jakkoyang wants to merge 1 commit into
PyCalendar:mainfrom
jakkoyang:fix-vskip-ical-value
Open

jakkoyang wants to merge 1 commit into
PyCalendar:mainfrom
jakkoyang:fix-vskip-ical-value

Conversation

@jakkoyang

Copy link
Copy Markdown

Linked issue

Description

vSkip didn't define its own ical_value, so it used the one inherited from vText, which returns str(self). Because vSkip is an Enum, that gave the qualified member name instead of the value, so vSkip.OMIT.ical_value returned 'vSkip.OMIT' instead of 'OMIT'.

  • adds an ical_value property to vSkip that returns the RFC 7529 value (OMIT, FORWARD or BACKWARD), with docstring and example
  • adds test_vSkip.py with two parametrized tests over all three members
  • There's also a news entry too

AI disclosure: I used Claude Opus 5.5 to help find the cause of the bug and plan the fix and tests and guidance but I wrote the code, tests, and news entry myself and ran everything locally.

Checklist

  • I added a change log entry, following the instructions in all subsections under Change log requirements.
  • I followed icalendar's Artificial intelligence policy and disclosed my Responsible AI use in my commit messages, if applicable.
  • I added or updated tests, if applicable.
  • I ran and ensured all tests pass locally by following Run tests.
  • I added or edited documentation as necessary, both as docstrings to be rendered in the API documentation and narrative documentation, following the Style guide.

Additional information

Before: vSkip.OMIT.ical_value == 'vSkip.OMIT'
After: vSkip.OMIT.ical_value == 'OMIT'

This is my first contribution to icalendar and Im doing this just to get more experience with open source as a whole... all tests pass locally (uv run pytest).

Part of PyCalendar#876.

AI: Claude Opus 5.5

Prompt (summary): help find why vSkip.ical_value returns 'vSkip.OMIT' and plan a fix and tests.

Output: Guidance only. I wrote the fix, tests, and news entry myself and ran the full test suite locally.
@github-actions

Copy link
Copy Markdown
Contributor

Thanks for the pull request, @jakkoyang! A maintainer will review it shortly.

@github-actions

Copy link
Copy Markdown
Contributor

Insufficient data

Not enough activity yet to make a reliable assessment.

View full analysis →

This is an automated analysis by AgentScan

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant