Repository navigation
Conversation
Part of PyCalendar#876. AI: Claude Opus 5.5 Prompt (summary): help find why vSkip.ical_value returns 'vSkip.OMIT' and plan a fix and tests. Output: Guidance only. I wrote the fix, tests, and news entry myself and ran the full test suite locally.
jakkoyang
requested review from
niccokunzmann and
stevepiercy
as code owners
November 13, 2026 03:26
Contributor
|
Thanks for the pull request, @jakkoyang! A maintainer will review it shortly. |
Contributor
Insufficient dataNot enough activity yet to make a reliable assessment. This is an automated analysis by AgentScan |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue
Description
vSkipdidn't define its ownical_value, so it used the one inherited fromvText, which returnsstr(self). BecausevSkipis an Enum, that gave the qualified member name instead of the value, sovSkip.OMIT.ical_valuereturned'vSkip.OMIT'instead of'OMIT'.ical_valueproperty tovSkipthat returns the RFC 7529 value (OMIT,FORWARDorBACKWARD), with docstring and exampletest_vSkip.pywith two parametrized tests over all three membersAI disclosure: I used Claude Opus 5.5 to help find the cause of the bug and plan the fix and tests and guidance but I wrote the code, tests, and news entry myself and ran everything locally.
Checklist
Additional information
Before:
vSkip.OMIT.ical_value == 'vSkip.OMIT'After:
vSkip.OMIT.ical_value == 'OMIT'This is my first contribution to icalendar and Im doing this just to get more experience with open source as a whole... all tests pass locally (
uv run pytest).