Skip to content

Add type hint to make_unique_tzname function #2104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kdaanish866 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add type hint to make_unique_tzname function #2104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f577d44
Add type hint to _make_unique_tzname
kdaanish866 Nov 12, 2026
2bf7af1
added doc file
kdaanish866 Nov 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions news/938.documentation.1
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Added argument and return type hints to :meth:`~icalendar.cal.timezone.Timezone._make_unique_tzname`. Located an untyped helper and confirm its call sites in ``get_transitions``. @kdaanish866
2 changes: 1 addition & 1 deletion src/icalendar/cal/timezone.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ def _extract_offsets(component: TimezoneDaylight | TimezoneStandard, tzname: str
return is_dst, transitions

@staticmethod
def _make_unique_tzname(tzname, tznames):
def _make_unique_tzname(tzname: str, tznames: set[str]) -> str:
"""
:param tzname: Candidate tzname
:param tznames: Other tznames
Expand Down
Loading