Skip to content

docs: fix broken docstring cross-references in icalendar.prop.recur - #2089

Open
dyno511 wants to merge 3 commits into
PyCalendar:mainfrom
dyno511:docs/fix-links-alarms
Open

dyno511 wants to merge 3 commits into
PyCalendar:mainfrom
dyno511:docs/fix-links-alarms

Conversation

@dyno511

@dyno511 dyno511 commented Nov 10, 2026 •

Copy link
Copy Markdown

Linked issue

Description

Checklist

  • I added a change log entry, following the instructions in all subsections under Change log requirements.
  • I followed icalendar's Artificial intelligence policy and disclosed my Responsible AI use in my commit messages, if applicable.
  • I added or updated tests, if applicable.
  • I ran and ensured all tests pass locally by following Run tests.
  • I added or edited documentation as necessary, both as docstrings to be rendered in the API documentation and narrative documentation, following the Style guide.

@github-actions

Copy link
Copy Markdown
Contributor

Thanks for the pull request, @dyno511! A maintainer will review it shortly.

@github-actions

Copy link
Copy Markdown
Contributor

Insufficient data

Not enough activity yet to make a reliable assessment.

View full analysis →

This is an automated analysis by AgentScan

@dyno511
dyno511 force-pushed the docs/fix-links-alarms branch 2 times, most recently from 57ef0e6 to cdfb721 Compare November 10, 2026 11:50
@stevepiercy

Copy link
Copy Markdown
Member

I think that after #2033 is merged, then this PR will become unnecessary.

See also #2095. datetime stuff will resolve with an update to sphinx-autodoc-typehints.

@dyno511 dyno511 changed the title docs: fix broken datetime cross-references in icalendar.cal.alarm docs: fix broken docstring cross-references in icalendar.prop.recur Nov 13, 2026
@dyno511

dyno511 commented Nov 13, 2026

Copy link
Copy Markdown
Author

Thank you @stevepiercy for pointing that out!

I have completely reverted the changes in src/icalendar/cal/alarm.py so that datetime/timedelta typehints can be handled as intended in #2033 / #2095.

Instead, I have updated this PR to fix the broken docstring cross-references in src/icalendar/prop/recur/recur.py where :class:icalendar.cal.Event and `:class:`icalendar.cal.Todo were missing the submodule path in vRecur docstrings. I also updated the title, description, and news fragment accordingly.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants