integtests: drop custom Arch image; provision older Python from setup.py#449
Merged
Conversation
The archlinux job used the custom gilgamezh/archlinux-python39 image only to have an older Python prebuilt for the cross-version test. archlinux:latest already ships the newest CPython, and uv can provide the older interpreter at runtime, so the custom image is no longer needed (nothing to maintain or rebuild). The cross-version target moves from EOL 3.9 to 3.11. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Standardize all integration jobs on uv for interpreter provisioning: - fedora: install uv from the distro and use it for the older cross-version target instead of `yum install python3.9`, which no longer resolves in current Fedora repos. Cross-version target moves from EOL 3.9 to 3.11. - native-windows / native-generic: replace actions/setup-python with astral-sh/setup-uv + `uv run`, which provisions both the matrix interpreter and the 3.10 cross-version target without per-OS path juggling. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
`uv run` executes the target command inside an ephemeral venv, and fades refuses to run inside a virtual environment (it is a venv manager itself), so the native-windows and native-generic jobs failed. Those jobs never needed uv: actions/setup-python already provides each matrix interpreter (and the 3.10 cross-version target) cleanly on every OS, without a venv wrapper. Revert them. The archlinux and fedora jobs keep uv: there fades runs under the system Python and uv only supplies the *target* interpreter path via `uv python find`, so no venv wrapping is involved. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Instead of hardcoding the older Python in each job, add a `min-python` job that reads the minimum supported version from setup.py's `python_requires` and exposes it as an output. Every job consumes that single source of truth: - archlinux / fedora: `uv python install` the minimum, target it for the cross-version run. - native-windows / native-generic: the matrix "oldest" entry and the cross-Python setup-python step both take the minimum from the output. Bumping the supported floor in setup.py now automatically updates the integration tests. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
gilgamezh
force-pushed
the
change_run_old
branch
from
cd6bcf0 to
e18283d
Compare
gilgamezh
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Modernizes interpreter provisioning in the integration tests and removes the custom
gilgamezh/archlinux-python39Docker image.Approach (revised)
gilgamezh/archlinux-python39:latest→archlinux:latest(already ships the newest CPython). The older interpreter for the cross-version test comes fromuv python install. fades runs under the system Python and uv only supplies the target interpreter path viauv python find— fades is not wrapped in a venv.uvfrom the distro instead ofyum install python3.9(which no longer resolves); older target via uv.actions/setup-python. An earlier attempt useduv run, but that executes fades inside an ephemeral venv, and fades refuses to run inside a virtualenv (it is a venv manager itself). setup-python provides each interpreter cleanly on every OS with no venv wrapper, so those jobs stay as they were.Single source of truth
A new
min-pythonjob parses the minimum supported version fromsetup.py'spython_requiresand exposes it as an output. Every job derives its cross-version target from that output instead of hardcoding — so bumping the floor insetup.pyautomatically updates the integration tests. (The>=3.10floor itself comes from #450.)Notes
needs.min-pythonoutput flows into the matrix and steps on every OS.🤖 Generated with Claude Code