Verify Dangerous Dave in the Deserted Pirate's Hideout! - #717
Open
mark-wd wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verifying Dangerous Dave in the Deserted Pirate's Hideout! (1990) (Softdisk Publishing)
Checklist
Have adequate installation instructions been provided to match any config files in the DOSZ?
Not applicable. The DOSZ contains no configuration files; it can be started directly with
DAVE.EXE.Have any official patches been applied, if necessary?
No official patch is necessary for the TDC-matched release.
Have digital versions (Steam, GOG) been checked for matching?
Yes. A separate GOG variant remains in the unverified digital-variants DAT; this PR verifies only the base TDC-matched release.
Can the game benefit from using embedded data or embedded patches in the datfile?
No. The archive contains only the original executable, data, and text files, with no reproducible configuration or patch data to embed.
Can DoDAT build the game from the install media?
Yes. DoDAT matches all three DAT members from the TDC source.
If the game requires a yml in the DOSZ, has it been added to the yml folder in the repo?
Not applicable. Runtime configuration is supplied by the DOSC.
Are there .PIF or .ICO or Win32 .EXE files that could be excluded?
No. The archive contains only
DAVE.EXE,DAVE.TXT, andEGADAVE.DAV.Do the file timestamps match the installation media?
Yes. The timestamps match the TDC source.
Does the DOSZ run standalone?
Yes. Run
DAVE.EXE.For CD games, can the game be set up to run without a CD mounted?
Not applicable; this is not a CD game.
Can the game benefit from using CHDtoOGG?
Not applicable; there are no CD audio tracks.
Is the game creating a swap file in the .pure.zip that could be avoided by increasing memory size? Or is it creating other bloated files that could be prevented by adding them in the DOSZ?
No unwanted or bloated runtime files were observed.
Does the DOSC contain problematic data (i.e. copyright issue)?
No. It contains only
DOS.YMLruntime settings.Does the DOSC have copy protection removed, if possible?
No copy protection was encountered.
Is the game running at the correct speed? Is CPU year specified?
Yes. The DOSC specifies
cpu_year: 1990.Is the DOSC auto-running and skipping past any obstructions? Does it use WAITMODECHANGE if possible?
Yes. It starts
DAVE.EXEand usesrun_input: (WAITMODECHANGE).Does the game have MT-32 support? If so, is it correctly using MT-32 (old) or CM-32L (new), going by the Vogons Wiki?
No.
Does the game have General MIDI support?
No.
Is the game set up to run with the best quality graphics options by default?
Yes. The game uses its included EGA data without additional configuration.
For certain old games only - are the graphics/audio improved by specifying video_card: pcjr, tandy, or generic_cga?
No additional video-card setting is needed.
Does the game have a mouse cursor that benefits from enabling input_directmouse?
No.
Does a game with separate episodes/executables have the options named and ordered properly in the DOSZ? Do they use the run_utility feature?
Not applicable; there is one game executable.
Does the game share saves with a sequel, expansion, etc? If so, is it updated to use the .savename feature?
Not applicable.
Is the game data in the root of the ZIP (unless game does not work that way)?
Yes. All three files are in the archive root.
Is the entry in the right variant file (i.e. Freeware)?
Yes. This is the base TDC-matched entry; the GOG release remains a separate digital variant.
For games which include CD images, is there a smaller installation variant that offers the same features but needs less files?
Not applicable; no CD image is included.
Summary of changes
unverified/dosctoverified/doscbyte-for-byte unchanged.