Language: wire lazy property PHPCfg marker → ReflectionProperty::isLazy (#16813)#16955
Merged
Merged
Conversation
Place phpc-lazy-property comment before visibility (php-parser leading comment recovery), add PHPCfg propertyLazy + Parser extraction, and fix VM\TypeCheck import in LazyPropertySupport. Refresh bootstrap inventory. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/*phpc-lazy-property*/marker before visibility (leading comment recovery like asymmetric visibility) so php-parser/PHPCfg preserve itpropertyLazyon PHPCfgProperty+extractLazyPropertyFromAttributes()in Parser (patch overlay)$child->propertyLazy; fixVM\TypeCheckimport inLazyPropertySupportdocs/bootstrap-inventory.mdfor lazy-property files on vm.php pathRoot cause
LazyPropertyRewriterembedded the marker betweenpublicand the type; php-parser only attaches leading comments toStmt\Property, sopropertyLazynever reachedDECLARE_PROPERTYandReflectionProperty::isLazy()was always false.Verification
Closes #16813
Made with Cursor