Skip to content

Make resulting cmake config relocatable#38

Open
bachp wants to merge 1 commit into
Pulse-Eight:masterfrom
bachp:relocatable-cmake
Open

Make resulting cmake config relocatable#38
bachp wants to merge 1 commit into
Pulse-Eight:masterfrom
bachp:relocatable-cmake

Conversation

@bachp

@bachp bachp commented Sep 28, 2018

Copy link
Copy Markdown

This change avoids hardcoded install prefix in the p8-platform-config.cmake.
Especially important when doing cross compilation with Yocto for example.

This change avoids hardcoded install prefix in the p8-platform-config.cmake.
Especially important when doing cross compilation with Yocto for example.
@MartijnKaijser

Copy link
Copy Markdown

Maybe try here
https://github.com/xbmc/platform

@bachp

bachp commented Oct 25, 2018

Copy link
Copy Markdown
Author

@MartijnKaijser Is this project dead? Or why do you suggest https://github.com/xbmc/platform?

@malard

malard commented Oct 25, 2018

Copy link
Copy Markdown
Member

This project isn't dead, we will review next week, thanks for the contribution!

@bachp

bachp commented Oct 25, 2018

Copy link
Copy Markdown
Author

The patch landed in OpenEmbedded where it was required to build without errors.

@opdenkamp

Copy link
Copy Markdown
Contributor

I haven't checked cmake's commit history, but the links in the manual to get_filename_component() suggest that this has been added in cmake 3.0, so cmake_minimum_required() needs to be updated too:

cmake_minimum_required(VERSION 2.8.9)

It also needs a quick rebase because of b784c04

thanks

@bachp

bachp commented Nov 5, 2018

Copy link
Copy Markdown
Author

I need to verify, but it could be that b784c04 made this change obsolete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants