Pass VSync toggle during rendering rather than only at startup - #363
Open
Acissathar wants to merge 1 commit into
Open
Pass VSync toggle during rendering rather than only at startup#363Acissathar wants to merge 1 commit into
Acissathar wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The swap interval is pushed once, at Start(). InternalWindow.VSync is the property Silk's own render loop would consult — and Prowl doesn't use that loop. So the setter updates a value nobody reads, and the toggle can never do anything at runtime. It only works via InitWindow's options because Start() reads it once afterwards.
This change makes it so that the setter now also stores it as a pending swap, which is read during the render loop as it needs the context.
I know there was mention on the Editor VSync issue (which this also covers in addition to builds) about looking into a more robust solution (framerate caps, etc.) so just wanted to at least throw this up should someone else want it if this isn't something that you want merged in lieu of the other solution.