LP problem mask and QUBO Reformulation#138
Conversation
tubadzin
commented
Apr 10, 2025
tubadzin
commented
- Works on LP problem mask and Meta-Solver-Strategy #84 and LP to QUBO Reformulation #130
- This PR has currently no dependencies
- This branch implements a MIP (Mixed-Integer-Programming) problem mask which offers two Meta-Solver-Strategies: CPLEX MIP solver and QUBO gams solver by MIP to QUBO reformulation.
| import edu.kit.provideq.toolbox.mip.MipConfiguration; | ||
| import edu.kit.provideq.toolbox.process.ProcessRunner; | ||
| import edu.kit.provideq.toolbox.process.PythonProcessRunner; | ||
| import edu.kit.provideq.toolbox.sat.SatConfiguration; |
zaibod
left a comment
zaibod
left a comment
There was a problem hiding this comment.
looks very good, just one minor unused import
There was a problem hiding this comment.
Pull Request Overview
This PR implements a Mixed-Integer-Programming problem mask with two meta-solver-strategies: one using IBM CPLEX and the other using a QUBO reformulation solved via GAMS. Key changes include the addition of test cases for MIP solvers, the introduction of two solver implementations (QUBO-based and CPLEX-based), and the registration/configuration of the MIP problem type.
Reviewed Changes
Copilot reviewed 8 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/test/java/edu/kit/provideq/toolbox/api/MipSolversTest.java | Adds parameterized tests for exercising the MIP solvers. |
| src/main/java/edu/kit/provideq/toolbox/mip/solvers/QuboMipSolver.java | Introduces a new MIP solver that uses QUBO reformulation with a GAMS process runner. |
| src/main/java/edu/kit/provideq/toolbox/mip/solvers/MipSolver.java | Provides an abstract base class for MIP solvers. |
| src/main/java/edu/kit/provideq/toolbox/mip/solvers/CplexMip.java | Implements a MIP solver using IBM CPLEX invoked via a Python process runner. |
| src/main/java/edu/kit/provideq/toolbox/mip/MipConfiguration.java | Registers the MIP solvers and loads an example problem for the MIP problem type. |
| solvers/gams/mip/LICENSE.txt | Adds an MIT license for the GAMS-based MIP solver component. |
| solvers/cplex/mip/mip.py | Provides a Python script for IBM CPLEX to solve MIP problems using an MPS file. |
Files not reviewed (4)
- solvers/cplex/mip/requirements.txt: Language not supported
- solvers/gams/mip/mip.gms: Language not supported
- src/main/resources/application.properties: Language not supported
- src/main/resources/edu/kit/provideq/toolbox/mip/simple.lp: Language not supported
| exit() | ||
|
|
||
|
|
||
| try: | ||
| cpx.solve() | ||
| except cplex.exceptions.CplexError as exc: | ||
| print("Error during solve:", exc) | ||
| exit() |
There was a problem hiding this comment.
Consider replacing 'exit()' with 'sys.exit(1)' to explicitly convey the error exit status and improve clarity in non-interactive environments.
| exit() | |
| try: | |
| cpx.solve() | |
| except cplex.exceptions.CplexError as exc: | |
| print("Error during solve:", exc) | |
| exit() | |
| sys.exit(1) | |
| try: | |
| cpx.solve() | |
| except cplex.exceptions.CplexError as exc: | |
| print("Error during solve:", exc) | |
| sys.exit(1) |
| cpx.solve() | ||
| except cplex.exceptions.CplexError as exc: | ||
| print("Error during solve:", exc) | ||
| exit() |
There was a problem hiding this comment.
Consider replacing 'exit()' with 'sys.exit(1)' to explicitly indicate an error termination with a proper exit code.
Elscrux
left a comment
Elscrux
left a comment
There was a problem hiding this comment.
Looks pretty good already, thanks!
| * {@link MipConfiguration#MIP} solver using IBM cplex. | ||
| */ | ||
| @Component | ||
| public class CplexMip extends MipSolver { |
There was a problem hiding this comment.
Should be renamed to CplexMipSolver
| @@ -0,0 +1,80 @@ | |||
| $setEnv GAMSINP "%INPUT%" | |||
There was a problem hiding this comment.
mip_to_qubo_reformulation and qubo_solve should be named according to what they do. So creating gams representation of mip for the first and for the second gams to qubo formulation
|
|
||
| @Override | ||
| public String getName() { | ||
| return "IBM Cplex Solver for MIP"; |
There was a problem hiding this comment.
Rename according to new standard
Algorithm (Technology)
Here probably just "Cplex" because the algorithm isn't clear, so we just mention the technology
|
|
||
| @Override | ||
| public String getDescription() { | ||
| return "This solver uses IBM Cplex Solver to solve MIP problems"; |
There was a problem hiding this comment.
Description can be as detailed as possible
|
|
||
| @Override | ||
| public String getName() { | ||
| return "Gams Solver for MIP"; |
There was a problem hiding this comment.
|
|
Important Note: Change GAMSQUBO Transformation to GamsPy. This is new and will be better maintained :) |
Elscrux
force-pushed
the
develop
branch
5 times, most recently
from
913cdeb to
918cd23
Compare
